Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] 14.0 - delivery - migration done #3299

Closed
wants to merge 1 commit into from

Conversation

legalsylvain
Copy link
Contributor

Quite simple migration script.

  • length has been renamed into packaging_length
  • I added comments in the noupdate_changes.xml to say why I don't load the data.

thanks for your review.

@OCA-git-bot
Copy link
Contributor

Hi @StefanRijnhart, @MiquelRForgeFlow, @pedrobaeza,
some modules you are maintaining are being modified, check this out!

@legalsylvain
Copy link
Contributor Author

Hi.

i don't understand why CI is failing.

At the end of the migration openupgrade try to make a delete on res.partner table...
https://github.com/OCA/OpenUpgrade/runs/6943798791?check_suite_focus=true#step:13:5198

ERROR: update or delete on table "res_partner" violates foreign key constraint "fleet_vehicle_assignation_log_driver_id_fkey" on table "fleet_vehicle_assignation_log"
DETAIL:  Key (id)=(31) is still referenced from table "fleet_vehicle_assignation_log".

In fact, in the last green build the delete are present at the end of the openupgrade log, but no error is raised...
https://github.com/OCA/OpenUpgrade/runs/6932502486?check_suite_focus=true#step:13:5177

Thanks for your help.

@legalsylvain
Copy link
Contributor Author

Something is wrong in the CI. Don't you think ?
#3300 is red, but I only added a text file...

@legalsylvain
Copy link
Contributor Author

And I rerun the test for #3289 (that was green). And it is now red.

@pedrobaeza
Copy link
Member

This is because Odoo has added a new restriction that makes this to fail (as Odoo part is always got dynamically, which is good, as it serves to see things that can fail in real scenarios):

odoo/odoo@91ceb95

We have to prevent such deletion searching which data is removing, and preventing it to be removed.

@MiquelRForgeFlow
Copy link
Contributor

FYI: #2998

@pedrobaeza
Copy link
Member

Then we can close this one, but that doesn't prevent to fix current problem in CI, which is independent from the migration of this module, and comes from an update upstream.

Miquel, can you check it?

@pedrobaeza pedrobaeza closed this Jun 20, 2022
@legalsylvain
Copy link
Contributor Author

FYI: #2998

Damn'it, the related main issue was not up to date. (#2190)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants